wip:

.github/workflows/main.yaml

@@ -4,8 +4,6 @@ on:
   push:
     branches:
       - "master"
-  schedule:
-    - cron: "0 2 * * 0"
 
 jobs:
   docker:

README.md

@@ -1 +1 @@
-# v1.01
+# v1.0

notifications.py

@@ -10,22 +10,15 @@ def send_notification(app, target_user, mapname, old_replay, new_replay):
         return
 
     # send to event dispatcher #
-    message = "TM: Record broken on {}\n\n".format(mapname)
-    message += "Old time:   {}\n".format(old_replay.get_human_readable_time())
-    message += "New time: {}\n".format(new_replay.get_human_readable_time())
-    message += "\nby {}".format(new_replay.clean_login())
+    message = "Trackmania: Record broken on {}".format(mapname)
+    message += "Old time: {}".format(old_replay.get_human_readable_time())
+    message += "New time: {}".format(new_replay.get_human_readable_time())
+    message += "by {}".format(new_replay.clean_login())
 
-    payload = {
-        "users": [target_user],
-        "msg" : message,
-        "method" : "any"
-    }
+    payload = { "users": [user], "msg" : message }
 
-    url_and_token = "/smart-send?dispatch-access-token={}".format(app.config["DISPATCH_TOKEN"])
-    r = requests.post(app.config["DISPATCH_SERVER"] + url_and_token, json=payload)
+    r = requests.post(app.config["DISPATCH_SERVER"] + "/smart-send",
+                    json=payload, auth=app.config["DISPATCH_AUTH"])
 
     if not r.ok:
-        msg = "Error handing off notification to dispatch ({} {})".format(r.status_code, r.content)
-        print(msg, file=sys.stderr)
-    else:
-        print("Handed off notification for {} to dispatch".format(target_user), file=sys.stderr)
+        print("Error handing off notification to dispatch ({})".format(r.status_code), file=sys.stderr)

req.txt

@@ -3,4 +3,3 @@ flask-sqlalchemy
 pygbx
 werkzeug
 xmltodict
-requests

server.py

@@ -10,7 +10,6 @@ import datetime
 
 from pygbx import Gbx, GbxType
 import tm2020parser
-import notifications
 
 import sqlalchemy
 from sqlalchemy import Column, Integer, String, Boolean, or_, and_, asc, desc
@@ -88,68 +87,8 @@ class UserSettings(db.Model):
     show_tmnf            = Column(Boolean)
     show_tm_2020_current = Column(Boolean)
 
-    notifications_all     = Column(Boolean)
-    notifications_self    = Column(Boolean)
-
-@app.route("/update-user-settings", methods=["GET", "POST"])
-def update_user_settings():
-
-    user = flask.request.headers.get("X-Forwarded-Preferred-Username")
-    user_helper = user or "anonymous"
-
-    settings = db.session.query(UserSettings).filter(UserSettings.user==user_helper).first()
-
-    # handle new settings #/
-    if not settings:
-        settings = UserSettings(user=user_helper, show_tm_2020=False, show_tmnf=False,
-                                    show_tm_2020_current=True, notifications_self=True,
-                                    notifications_all=False)
-        db.session.add(settings)
-        db.session.commit()
-        settings = db.session.query(UserSettings).filter(UserSettings.user==user_helper).first()
-
-
-    if flask.request.method == "GET":
-
-        key = flask.request.args.get("key")
-
-        # some sanity checks #
-        if not key:
-            return ("key missing in args", 422)
-        if key == "user" or key.startswith("_") or "sql" in key:
-            return ("key {} is not allowed".format(key), 422)
-
-        # return attribute #
-        return (str(getattr(settings, key)), 200)
-
-    elif flask.request.method == "POST":
-        json_dict = flask.request.json
-        key_value_list = json_dict.get("payload")
-
-        if not key_value_list:
-            return ("'payload' field empty", 422)
-
-        for el in key_value_list:
-
-            key = el.get("key")
-            value = el.get("value")
-
-            if key == "user" or key.startswith("_") or "sql" in key:
-                return ("key {} is not allowed".format(key), 422)
-
-            if key is None or value is None:
-                return ("element in payload list does not contain key and value", 422)
-          
-            try:
-                getattr(settings, key)
-                setattr(settings, key, bool(value))
-                db.session.merge(settings)
-                db.session.commit()
-                return ("", 204)
-            except AttributeError:
-                return ("key {} not part of user settings".format(key), 422)
-    else:
-        raise AssertionError("Unsupported Method: {}".format(flask.request.method))
+    notifcations_all     = Column(Boolean)
+    notifcations_self    = Column(Boolean)
 
 class ParsedReplay(db.Model):
 
@@ -177,16 +116,13 @@ class ParsedReplay(db.Model):
         else:
             return self.login
 
-    def get_human_readable_time(self):
+    def get_human_readable_time(self, thousands=False):
         t = datetime.timedelta(microseconds=self.race_time*1000)
         t_string = str(t)
         if t.seconds < 60*60:
             t_string =  t_string[2:]
         if t.microseconds != 0:
-            if self.game == "tmnf":
-                return t_string[:-4]
-            else:
-                return t_string[:-3]
+            return t_string[:-4]
         return t_string + ".00"
 
     def __repr__(self):
@@ -400,24 +336,17 @@ def mapnames():
     '''Index Location'''
 
     # TODO list by user
-    player = flask.request.headers.get("X-Forwarded-Preferred-Username") or "anonymous"
+    player = flask.request.headers.get("X-Forwarded-Preferred-Username")
     maps_query = db.session.query(Map).order_by(asc(Map.mapname))
 
     # limit leaderboard to game #
-    settings = db.session.query(UserSettings).filter(UserSettings.user==player).first()
-    if settings:
-        if not settings.show_tm_2020 and not settings.show_tmnf:
-            maps_query = maps_query.filter(Map.game=="tm2020")
-            latest_season = tm2020parser.get_latest_season_from_maps(maps_query.all())
-            # handle no replays #
-            if latest_season:
-                maps_query = maps_query.filter(Map.map_uid.like("{}%".format(latest_season)))
-        elif settings.show_tm_2020 and not settings.show_tmnf:
-            maps_query = maps_query.filter(Map.game=="tm2020")
-        elif not settings.show_tm_2020 and settings.show_tmnf:
-            maps_query = maps_query.filter(Map.game=="tmnf")
-        else:
-            pass
+    game = flask.request.args.get("game")
+    if game == "tm2020":
+        maps_query = maps_query.filter(Map.game=="tm2020")
+    elif game=="tmnf":
+        maps_query = maps_query.filter(Map.game!="tm2020")
+    else:
+        pass
 
     maps = maps_query.all()
 
@@ -492,13 +421,12 @@ def upload():
 
 def check_replay_trigger(replay):
 
-    map_obj = db.session.query(Map).filter(Map.map_uid == replay.map_uid).first()
+    map_obj = db.session.get(Map).filter(Map.map_uid == replay.map_uid).first()
+    assert(map_uid)
+
     best = map_obj.get_best_replay()
     second = map_obj.get_second_best_replay()
 
-    if not second:
-        return
-
     if replay.filehash != best.filehash:
         return
 
@@ -506,7 +434,7 @@ def check_replay_trigger(replay):
         return
 
     settings = db.session.query(UserSettings).filter(UserSettings.user == second.uploader).first()
-    if settings and settings.notifications_self:
+    if settings and settings.notifcations_self:
         notifications.send_notification(app, settings.user, map_obj.map_uid, second, replay)
 
 def create_app():
@@ -515,7 +443,7 @@ def create_app():
 
     app.config["DISPATCH_SERVER"] = os.environ.get("DISPATCH_SERVER")
     if app.config["DISPATCH_SERVER"]:
-        app.config["DISPATCH_TOKEN"] = os.environ["DISPATCH_TOKEN"]
+        app.config["DISPATCH_AUTH"] = (os.environ["DISPATCH_AUTH_USER"], os.environ["DISPATCH_AUTH_PASSWORD"])
 
 if __name__ == "__main__":
 

static/site.css

@@ -27,15 +27,6 @@ table{
     border-color: transparent;
 }
 
-.user-settings{
-    display: inline-flex;
-    color: white;
-}
-
-.form-check{
-    margin-right: 15px;
-}
-
 .m-auto{
     margin: auto;
 }

static/user_settings.js

@@ -1,47 +0,0 @@
-/* event listener for all sliders */
-const sliders = Array.from(document.getElementsByClassName("form-check-input"))
-
-/* safety switch -> never run set before get */
-var sliders_set = false
-
-/* defer */
-sliders_load_all()
-
-/* get initial values & set listeners */
-function sliders_load_all(){
-    Promise.all(sliders.map(s => {
-        fetch("/update-user-settings?key=" + s.id, { credentials: "include" }).then(response => {
-            response.text().then(data => {
-                if(data == "True"){
-                    s.checked = true
-                }
-            })
-        })
-        s.addEventListener("change", submit)
-    })).then(
-        sliders_set = true
-    )
-}
-
-/* submit settings */
-function submit(e){
-
-    console.log("submit")
-    if(!sliders_set){
-        return
-    }
-
-    const s = e.target
-    const json_data = JSON.stringify({ payload : [ { key : s.id, value : s.checked } ] })
-    fetch("/update-user-settings", { 
-                method: "POST",
-                credentials: "include",
-                headers: {'Content-Type': 'application/json'},
-                body: json_data
-            }
-    ).then(response => {
-        if(s.id.startsWith("show")){
-            window.location.reload()
-        }
-    })
-}

templates/index.html

@@ -3,24 +3,15 @@
 </head>
 <body>
     {% include "upload-button.html" %}
-
-    <div class="user-settings">
-        <div class="form-check form-switch">
-            <input class="form-check-input" type="checkbox" role="switch" id="show_tm_2020">
-            <label class="form-check-label" for="show_tm_2020">Show All TM2020</label>
-        </div>
-        <div class="form-check form-switch">
-            <input class="form-check-input" type="checkbox" role="switch" id="show_tmnf">
-            <label class="form-check-label" for="show_tmnf">Show All TMNF</label>
-        </div>
-        <div class="form-check form-switch">
-            <input class="form-check-input" type="checkbox" role="switch" id="notifications_self">
-            <label class="form-check-label" for="notifications_self">Send notifcations</label>
-        </div>
-    </div>
-
-    <script src="/static/user_settings.js" defer></script>
-    
+    <button class="ml-4 mt-4 mb-4 btn btn-info" onclick="window.location.href='/?game=tmnf'">
+        TMNF
+    </button>
+    <button class="mt-4 mb-4 btn btn-info" onclick="window.location.href='/?game=tm2020'">
+        TM2020
+    </button>
+    <button class="mt-4 mb-4 btn btn-info" onclick="window.location.href='/'">
+        All
+    </button>
     <table class="m-auto">
 	<thead>
 		<tr>

tm2020parser.py

@@ -5,41 +5,6 @@ import hashlib
 import pygbx
 import xmltodict
 
-def get_latest_season_from_maps(maps):
-    '''Determine the latest season in DB'''
-
-    order = ["Winter", "Spring", "Summer", "Fall"]
-
-    max_year = 0
-    max_season = "Winter"
-
-    if not maps:
-        return
-
-    for m in maps:
-        splitted = m.map_uid.split(" ")
-
-        # not a campain map #
-        if len(splitted) < 3:
-            return
-
-        season = splitted[0]
-        year = splitted[1]
-
-        # also not a campaing map #
-        if not season in order:
-            return
-        try:
-            year = int(year)
-        except ValueError:
-            return
-
-        if year > max_year or year == max_year and order.index(season) >= order.index(max_season):
-            max_year = year
-            max_season = season
-
-    return "{} {}".format(max_season, max_year)
-
 class GhostWrapper():
 
     def __init__(self, fullpath, uploader):