sheppy/colorredstderr-mirror
1
0
Fork 0
mirror of https://github.com/FAUSheppy/colorredstderr-mirror synced 2025-12-06 07:01:38 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve checks for invalid file descriptors.

Browse Source 
Just in case a real dup*() or fcntl() doesn't return -1 on error, but
something like -2.
This commit is contained in:
Simon Ruderich
2013-06-21 22:55:13 +02:00
parent 219a9882ba
commit 2fc66e15eb
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/coloredstderr.c
View File

@@ -406,7 +406,7 @@ HOOK_FUNC_DEF1(int, dup, int, oldfd) {
DLSYM_FUNCTION(real_dup, "dup");
newfd = real_dup(oldfd);
if (newfd != -1) {
if (newfd > -1) {
dup_fd(oldfd, newfd);
}
@@ -417,7 +417,7 @@ HOOK_FUNC_DEF2(int, dup2, int, oldfd, int, newfd) {
DLSYM_FUNCTION(real_dup2, "dup2");
newfd = real_dup2(oldfd, newfd);
if (newfd != -1) {
if (newfd > -1) {
dup_fd(oldfd, newfd);
}
@@ -428,7 +428,7 @@ HOOK_FUNC_DEF3(int, dup3, int, oldfd, int, newfd, int, flags) {
DLSYM_FUNCTION(real_dup3, "dup3");
newfd = real_dup3(oldfd, newfd, flags);
if (newfd != -1) {
if (newfd > -1) {
dup_fd(oldfd, newfd);
}
@@ -460,7 +460,7 @@ HOOK_FUNC_VAR_DEF2(int, fcntl, int, fd, int, cmd /*, ... */) {
va_end(ap);
/* We only care about duping fds. */
if (cmd == F_DUPFD && result != -1) {
if (cmd == F_DUPFD && result > -1) {
dup_fd(fd, result);
}