Simon Ruderich
1068648718
Minor documentation update.
2013-06-15 02:21:27 +02:00
Simon Ruderich
0a909cac79
Use locally defined functions in hooks where possible.
...
Don't create a hook and call the "real" function when it's enough to
call an existing hook for this function.
2013-06-15 01:58:36 +02:00
Simon Ruderich
217e8c8bc5
Define real_*() static variables with macros.
2013-06-15 00:54:46 +02:00
Simon Ruderich
18d52b3b5a
Install libcoloredstderr.so read-only.
...
Prevents accidental truncates of libcoloredstderr.so with `cp` which
crash all programs which have loaded it.
2013-06-14 13:40:06 +02:00
Simon Ruderich
1d1b6d7769
Remove duplicate code in init_from_environment().
2013-06-13 22:15:49 +02:00
Simon Ruderich
45d25526c0
Minor documentation updates.
2013-06-13 22:15:09 +02:00
Simon Ruderich
3d46e3ab9b
Add missing const and document where it can't be used.
2013-06-13 22:13:16 +02:00
Simon Ruderich
59375c2b79
Fix possible memory overwrite in init_from_environment().
...
It was possible for a user to overwrite memory at a relative location
with 1 by passing a negative file descriptor.
2013-06-13 22:08:08 +02:00
Simon Ruderich
f30dbbd26d
Add more error checks.
2013-06-13 21:56:50 +02:00
Simon Ruderich
e5a94fa847
Remove unnecessary calls to update_environment() in exec*().
2013-06-13 21:50:51 +02:00
Simon Ruderich
1e02760898
constants.h: Fix indentation.
2013-06-13 21:45:19 +02:00
Simon Ruderich
7eb1667d41
ldpreload.h: Add missing unlikely() in DLSYM_FUNCTION().
2013-06-13 21:44:55 +02:00
Simon Ruderich
0ad5e4db04
hookmacros.h: Remove duplication in _HOOK_PRE_FD_/_HOOK_PRE_FILE.
2013-06-13 21:44:55 +02:00
Simon Ruderich
d171e6bbec
trackfds.h: Add missing inline for consistency.
2013-06-13 21:34:29 +02:00
Simon Ruderich
6d6ad4423a
Add assert()s.
2013-06-13 21:33:27 +02:00
Simon Ruderich
37cb5686de
Handle invalid arguments to close()/fclose() better.
2013-06-13 21:19:15 +02:00
Simon Ruderich
7adfbfd2cf
Fix hook for putc_unlocked() with glibc.
...
putc_unlocked() is a macro which expands to __overflow() in some cases.
2013-06-13 12:59:12 +02:00
Simon Ruderich
52b4e91146
hookmacros.h: Minor style fix.
2013-06-13 01:27:45 +02:00
Simon Ruderich
9af3c2c727
Add another debug() print to init_from_environment().
2013-06-10 22:25:31 +02:00
Simon Ruderich
779ba750f7
Fix compilation with clang.
2013-06-10 21:27:12 +02:00
Simon Ruderich
237251ae9c
Hook execvpe(), a GNU extension.
2013-06-10 17:10:44 +02:00
Simon Ruderich
55e8d0d38a
coloredstderr.c: Fix parameter name in execvp().
2013-06-10 16:58:27 +02:00
Simon Ruderich
7c2d726cd4
coloredstderr.c: Fix indentation.
2013-06-10 16:55:25 +02:00
Simon Ruderich
357a499884
configure.ac: Add --enable-warnings.
...
Enables warning() messages without the overhead of all debug output.
2013-06-10 16:18:35 +02:00
Simon Ruderich
afca2864dc
tests: Fix warnings about unused parameters.
2013-06-10 15:22:17 +02:00
Simon Ruderich
b75b0ec399
Rename __noinline/__always_inline to prevent clash with headers.
...
With this change noinline can be used in ldpreload.h.
2013-06-10 14:55:13 +02:00
Simon Ruderich
488159627f
Prevent inlining for more functions.
...
Clang is inlining quite aggressively.
2013-06-10 14:11:04 +02:00
Simon Ruderich
428e15bf68
Prevent inlining of handle_*_pre/post() functions.
2013-06-10 14:05:51 +02:00
Simon Ruderich
f3bda26e82
Don't mark init_pre_post_string() as inline.
2013-06-10 14:05:51 +02:00
Simon Ruderich
86352712fd
Fix save/restore of errno for isatty().
2013-06-10 14:05:51 +02:00
Simon Ruderich
0a2617527c
Inline fast part of tracked_fds_find().
2013-06-10 14:05:51 +02:00
Simon Ruderich
048bd6f9e7
Use likely()/unlikely() macros to improve branch prediction.
2013-06-10 14:05:51 +02:00
Simon Ruderich
9862b8c8f1
Inline check_handle_fd() into hook macros.
...
It's very small and prologue/epilogue have a lot of overhead.
2013-06-10 14:05:51 +02:00
Simon Ruderich
3773b830ba
ldpreload.h: Split macro into function and macro.
2013-06-10 14:05:50 +02:00
Simon Ruderich
dfd317650f
Remove errno save/restore where not necessary.
2013-06-10 14:05:45 +02:00
Simon Ruderich
fe3f7d4c63
handle_*_pre(),handle_*_post(): Remove unused action parameter.
2013-06-10 04:53:30 +02:00
Simon Ruderich
30876b212c
constants.h: Use "\033" instead of the non-standard "\e".
2013-06-09 16:26:36 +02:00
Simon Ruderich
bcd5f79080
Remove unused hook puts_unlocked().
...
This function doesn't exist (yet).
2013-06-07 02:06:57 +02:00
Simon Ruderich
06f483dbee
Fix a few strict compiler warnings.
2013-06-07 02:01:23 +02:00
Simon Ruderich
7691b7aa1a
trackfds.h: Remove incorrect debug output.
2013-06-07 01:59:27 +02:00
Simon Ruderich
31a1fdf921
Use char const * instead of const char *.
...
char const * is more consistent with char * const.
2013-06-07 01:56:02 +02:00
Simon Ruderich
c2097785e7
Use static list of descriptors to reduce mallocs.
...
Only if file descriptors with a value > 255 occur, the list
implementation is used.
2013-06-07 01:27:58 +02:00
Simon Ruderich
7337375e05
Add warning() and use it in DEBUG mode.
2013-06-07 00:58:16 +02:00
Simon Ruderich
51377106d1
Rename tracked_fds_* tracked_fds_list_*.
2013-06-06 20:44:10 +02:00
Simon Ruderich
5af5f0faa2
debug.h: Minor code style fix.
2013-06-06 20:13:04 +02:00
Simon Ruderich
7f9856c5da
Hook error() and error_at_line() if available.
...
They are used by some GNU programs to display error messages.
2013-06-05 23:57:05 +02:00
Simon Ruderich
b140cc0a82
coloredstderr.c: Use #include <config.h>.
...
This ensures that config.h from the build directory is preferred over a
possible file of the same name in the source directory.
2013-06-05 18:11:33 +02:00
Simon Ruderich
4d10935aee
check_handle_fd(): Reduce calls to isatty().
2013-06-05 03:33:08 +02:00
Simon Ruderich
feff94de6b
trackfds.h: Remove unnecessary strdup().
2013-06-05 03:16:59 +02:00
Simon Ruderich
7ea72c40db
Hook execve() and the other exec*() functions.
...
Prevents programs from removing our environment variables during the
exec.
Also reduces unnecessary calls to update_environment() by calling it
only once before the exec.
2013-06-05 01:40:56 +02:00